feat(runtimes): add support for ClusterTrainingRuntimes in Helm chart #3124
+1,362
−10
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Example values.yaml configuration for deploying ClusterTrainingRuntimes | ||
|
|
||
| # Deploy torch-distributed runtime (no custom images needed) | ||
| runtimes: | ||
| torchDistributed: | ||
| enabled: true | ||
|
|
||
| # Deploy torch-distributed with data cache support | ||
| torchDistributedWithCache: | ||
| enabled: true | ||
| # cacheImage will use chart version by default | ||
| # To override, specify custom tag: | ||
| # cacheImage: | ||
| # tag: "v2.0.0" | ||
|
|
||
| # Deploy DeepSpeed runtime | ||
khushiiagrawal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| deepspeedDistributed: | ||
| enabled: true | ||
| # Override image tag if needed: | ||
| # image: | ||
| # tag: "custom-v1.0.0" | ||
|
|
||
| # Deploy MLX runtime | ||
| mlxDistributed: | ||
| enabled: false | ||
| # Can enable and customize: | ||
| # enabled: true | ||
| # image: | ||
| # registry: my-registry.io | ||
| # repository: custom/mlx-runtime | ||
| # tag: "v1.0.0" | ||
|
|
||
| # Note: torch-distributed-with-cache requires data cache support | ||
| dataCache: | ||
| enabled: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| {{- /* | ||
| Copyright 2025 The Kubeflow authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| https://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ -}} | ||
|
|
||
| {{- if or .Values.runtimes.deepspeedDistributed.enabled .Values.runtimes.defaultEnabled }} | ||
|
Member
There was a problem hiding this comment. You need to check for defaultEnabled in these runtimes too: mlx, torch, torchtune runtimes.
Contributor
Author
There was a problem hiding this comment. thanks for the review. i've updated the others (mlx, torch and torchtune) to respect the defaultEnabled flag as well. |
||
| apiVersion: trainer.kubeflow.org/v1alpha1 | ||
| kind: ClusterTrainingRuntime | ||
| metadata: | ||
| name: deepspeed-distributed | ||
| labels: | ||
| trainer.kubeflow.org/framework: deepspeed | ||
| {{- include "trainer.labels" . | nindent 4 }} | ||
| spec: | ||
| mlPolicy: | ||
| numNodes: 1 | ||
| mpi: | ||
| numProcPerNode: 1 | ||
| mpiImplementation: OpenMPI | ||
| sshAuthMountPath: /home/mpiuser/.ssh | ||
| runLauncherAsNode: true | ||
| template: | ||
| spec: | ||
| network: | ||
| publishNotReadyAddresses: true | ||
| successPolicy: | ||
| operator: All | ||
| targetReplicatedJobs: | ||
| - launcher | ||
| replicatedJobs: | ||
| - name: launcher | ||
| template: | ||
| metadata: | ||
| labels: | ||
| trainer.kubeflow.org/trainjob-ancestor-step: trainer | ||
| spec: | ||
| template: | ||
| spec: | ||
| containers: | ||
| - name: node | ||
| image: {{ include "trainer.runtimeImage" (list .Values.runtimes.deepspeedDistributed.image .) }} | ||
| securityContext: | ||
| runAsUser: 1000 | ||
| - name: node | ||
| template: | ||
| spec: | ||
| template: | ||
| spec: | ||
| containers: | ||
| - name: node | ||
| image: {{ include "trainer.runtimeImage" (list .Values.runtimes.deepspeedDistributed.image .) }} | ||
| securityContext: | ||
| runAsUser: 1000 | ||
| command: | ||
| - /usr/sbin/sshd | ||
| args: | ||
| - -De | ||
| - -f | ||
| - /home/mpiuser/.sshd_config | ||
| readinessProbe: | ||
| tcpSocket: | ||
| port: 2222 | ||
| initialDelaySeconds: 5 | ||
| {{- end }} | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add example where enabledDefault is true