fix(manifests): Remove jobset and lws patches from kustomize deployment by yosri-brh · Pull Request #3141 · kubeflow/trainer

yosri-brh · 2026-01-27T09:52:38Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it
Remove jobset and lws patches from kustomize deployment. The upstream projects now include proper labels:

Add jobset labels when deployed with kustomize kubernetes-sigs/jobset#1120
chore(deps): bump github.com/onsi/ginkgo/v2 from 2.27.3 to 2.27.5 kubernetes-sigs/lws#735

/cc @akshaychitneni

Which issue(s) this PR fixes
Fixes #3123

Special notes for your reviewer
Upstream fixes have been merged.

Does this PR introduce a user-facing change?
No

github-actions · 2026-01-27T09:52:47Z

🎉 Welcome to the Kubeflow Trainer! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
Our team will review your PR soon! cc @kubeflow/kubeflow-trainer-team

Join the community:

Slack: Join our #kubeflow-trainer Slack channel.
Meetings: Attend the Kubeflow AutoML and Training Working Group bi-weekly meetings.

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

andreyvelich · 2026-01-27T12:40:59Z

manifests/third-party/leaderworkerset/kustomization.yaml

+  # Update LWS webhook service selector to use unique label
+  - path: patches/webhook_service_selector.yaml
+    target:
+      group: ""
+      version: v1
+      kind: Service
+      name: lws-webhook-service
+  # Update LWS metrics service selector to use unique label
+  - path: patches/metrics_service_selector.yaml
+    target:
+      group: ""
+      version: v1
+      kind: Service
+      name: lws-controller-manager-metrics-service


Remove these patches as well.

Done. Removed all label-related patches for both JobSet and LWS. 003e8a0

coveralls · 2026-01-27T12:44:05Z

Pull Request Test Coverage Report for Build 21429394391

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.217%

Totals
Change from base Build 21420370777:	0.0%
Covered Lines:	1241
Relevant Lines:	2423

💛 - Coveralls

andreyvelich

Thanks for the update @yosri-brh!
We should update LWS and JobSet version before merging this PR.
/hold

andreyvelich · 2026-01-27T23:54:39Z

@yosri-brh Please rebase your PR.

manifests/third-party/leaderworkerset/kustomization.yaml

Signed-off-by: Yosri Barhoumi <med.yosri.brh@gmail.com>

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Yosri Barhoumi <44350807+yosri-brh@users.noreply.github.com> Signed-off-by: Yosri Barhoumi <med.yosri.brh@gmail.com>

andreyvelich · 2026-01-28T13:23:37Z

/ok-to-test
/lgtm
/approve

akshaychitneni · 2026-01-28T14:29:51Z

Thanks @yosri-brh
/approve

google-oss-prow · 2026-01-28T14:30:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akshaychitneni, andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [andreyvelich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andreyvelich · 2026-01-28T14:59:39Z

/hold cancel

google-oss-prow bot requested a review from akshaychitneni January 27, 2026 09:52

google-oss-prow bot added the kind/cleanup label Jan 27, 2026

google-oss-prow bot added the size/L label Jan 27, 2026

yosri-brh changed the title ~~fix(manifests): Remove jobset and lws patches from kustomize deploymentRemove jobset and lws patches from kustomize deployment~~ fix(manifests): Remove jobset and lws patches from kustomize deployment Jan 27, 2026

andreyvelich reviewed Jan 27, 2026

View reviewed changes

yosri-brh requested a review from andreyvelich January 27, 2026 13:23

andreyvelich reviewed Jan 27, 2026

View reviewed changes

google-oss-prow bot added the do-not-merge/hold label Jan 27, 2026

yosri-brh force-pushed the fix/remove-jobset-lws-patches branch from 003e8a0 to 5c0e017 Compare January 28, 2026 01:06

yosri-brh requested a review from andreyvelich January 28, 2026 01:10

andreyvelich reviewed Jan 28, 2026

View reviewed changes

manifests/third-party/leaderworkerset/kustomization.yaml Outdated Show resolved Hide resolved

yosri-brh and others added 4 commits January 28, 2026 08:35

Remove jobset and lws patches from kustomize deployment

e83175f

Signed-off-by: Yosri Barhoumi <med.yosri.brh@gmail.com>

Remove remaining LWS patches

4c87dff

Signed-off-by: Yosri Barhoumi <med.yosri.brh@gmail.com>

Remove jobset and lws label patches from kustomize deployment

204d8fd

Signed-off-by: Yosri Barhoumi <med.yosri.brh@gmail.com>

Apply suggestion from @andreyvelich

d5d1926

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Yosri Barhoumi <44350807+yosri-brh@users.noreply.github.com> Signed-off-by: Yosri Barhoumi <med.yosri.brh@gmail.com>

yosri-brh force-pushed the fix/remove-jobset-lws-patches branch from 6e1c489 to d5d1926 Compare January 28, 2026 07:36

yosri-brh requested a review from andreyvelich January 28, 2026 07:41

google-oss-prow bot added the ok-to-test label Jan 28, 2026

google-oss-prow bot assigned andreyvelich Jan 28, 2026

google-oss-prow bot added lgtm approved labels Jan 28, 2026

google-oss-prow bot removed the do-not-merge/hold label Jan 28, 2026

google-oss-prow bot merged commit e677503 into kubeflow:master Jan 28, 2026
34 of 35 checks passed

google-oss-prow bot added this to the v2.2 milestone Jan 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(manifests): Remove jobset and lws patches from kustomize deployment#3141

fix(manifests): Remove jobset and lws patches from kustomize deployment#3141
google-oss-prow[bot] merged 4 commits intokubeflow:masterfrom
yosri-brh:fix/remove-jobset-lws-patches

yosri-brh commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

andreyvelich Jan 27, 2026

Uh oh!

yosri-brh Jan 27, 2026

Uh oh!

coveralls commented Jan 27, 2026 •

edited

Loading

Uh oh!

andreyvelich left a comment

Uh oh!

andreyvelich commented Jan 27, 2026

Uh oh!

Uh oh!

andreyvelich commented Jan 28, 2026

Uh oh!

akshaychitneni commented Jan 28, 2026

Uh oh!

google-oss-prow bot commented Jan 28, 2026

Uh oh!

andreyvelich commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

yosri-brh commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

andreyvelich Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

yosri-brh Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21429394391

Details

💛 - Coveralls

Uh oh!

andreyvelich left a comment

Choose a reason for hiding this comment

Uh oh!

andreyvelich commented Jan 27, 2026

Uh oh!

Uh oh!

andreyvelich commented Jan 28, 2026

Uh oh!

akshaychitneni commented Jan 28, 2026

Uh oh!

google-oss-prow bot commented Jan 28, 2026

Uh oh!

andreyvelich commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Jan 27, 2026 •

edited

Loading