Deploy default-storage-class addon by default#3332
Open
kron4eg wants to merge 2 commits intokubermatic:mainfrom
Open
Deploy default-storage-class addon by default#3332kron4eg wants to merge 2 commits intokubermatic:mainfrom
kron4eg wants to merge 2 commits intokubermatic:mainfrom
Conversation
Unless it's already configured and there is no another default StorageClass Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
kubermatic-bot
added
docs/tbd
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
xmudrii
requested changes
Aug 6, 2024
Comment on lines
+164
to
+168
| if !foundDefaultStorageClass { | ||
| addonsToDeploy = append(addonsToDeploy, addonAction{ | ||
| name: resources.AddonDefaultStorageClass, | ||
| }) | ||
| } |
Member
There was a problem hiding this comment.
We should have a way to disable deployment of this addon. Do we already have that in place?
Member
Author
There was a problem hiding this comment.
no. there was no such way.
Member
Author
There was a problem hiding this comment.
Well, with delete: true it will be deleted everytime (which after the first time will have no affect any more). And once the used will have own default SC, this addon will be stopped from adding.
kubermatic-bot
added
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Member
|
/lgtm cancel |
Member
|
/hold cancel |
kubermatic-bot
removed
the
do-not-merge/hold
xmudrii
changed the title
kubermatic-bot
added
the
do-not-merge/work-in-progress
xmudrii
changed the title
kubermatic-bot
removed
the
do-not-merge/work-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless it's already configured and there is no another default StorageClass
Which issue(s) this PR fixes:
Fixes #2708
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: