Skip to content

fix ExecCredentialResponse deserializion in aot #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,13 @@ public class ExecCredentialResponse
public class ExecStatus
{
#nullable enable
[JsonPropertyName("expirationTimestamp")]
public DateTime? ExpirationTimestamp { get; set; }
[JsonPropertyName("token")]
public string? Token { get; set; }
[JsonPropertyName("clientCertificateData")]
public string? ClientCertificateData { get; set; }
[JsonPropertyName("clientKeyData")]
public string? ClientKeyData { get; set; }
#nullable disable

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
namespace k8s.KubeConfigModels
{
[JsonSerializable(typeof(ExecCredentialResponse))]
internal partial class ExecCredentialResponseContext : JsonSerializerContext
{
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,10 @@ public static ExecCredentialResponse ExecuteExternalCommand(ExternalExecution co
throw new KubeConfigException("external exec failed due to timeout");
}

var responseObject = KubernetesJson.Deserialize<ExecCredentialResponse>(process.StandardOutput.ReadToEnd());
var responseObject = JsonSerializer.Deserialize(
process.StandardOutput.ReadToEnd(),
ExecCredentialResponseContext.Default.ExecCredentialResponse);

if (responseObject == null || responseObject.ApiVersion != config.ApiVersion)
{
throw new KubeConfigException(
Expand Down
Loading