Skip to content

feat: enhance Kubernetes client with watch functionality #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
+645 −91
Open

feat: enhance Kubernetes client with watch functionality #1667

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
80b46b7
feat: enhance Kubernetes client with watch functionality
lqlive Sep 15, 2025
6979dd5
refactor: simplify watch event handling in Kubernetes client example
lqlive Sep 16, 2025
136b103
refactor: update Kubernetes watch functionality to use new event hand…
lqlive Sep 17, 2025
f9a3d9c
fix
lqlive Sep 17, 2025
201be85
fix
lqlive Sep 17, 2025
942a645
Merge branch 'master' into master
lqlive Sep 17, 2025
9ac1f9c
fix: correct usage of Pod list items in client example and update Obs…
lqlive Sep 18, 2025
4d752ed
fix: update client example to use correct Pod list method and improve…
lqlive Sep 23, 2025
5e47c09
Merge branch 'kubernetes-client:master' into master
lqlive Sep 23, 2025
6de5558
refactor: enhance type resolution for list items in TypeHelper by add…
lqlive Sep 23, 2025
c6bda21
feat: mark Watch methods as obsolete to prepare for future deprecation
lqlive Sep 24, 2025
85d7011
fix
lqlive Sep 28, 2025
0877710
refactor: update WatcherExt class to internal and remove obsolete att…
lqlive Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 28 additions & 5 deletions src/LibKubernetesGenerator/TypeHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,12 +246,14 @@

break;
case "T":
// Return single item type from list type (e.g., V1Pod from V1PodList)
return !string.IsNullOrEmpty(t) && t.EndsWith("List", StringComparison.Ordinal)
? t.Substring(0, t.Length - 4)
: t;
var itemType = TryGetItemTypeFromSchema(response);
if (itemType != null)
{
return itemType;
}

break;
case "TList":
// Return list type as-is
return t;
}

Expand Down Expand Up @@ -291,5 +293,26 @@

return false;
}

private string TryGetItemTypeFromSchema(OpenApiResponse response)
{
var listSchema = response?.Schema?.Reference;
if (listSchema?.Properties?.TryGetValue("items", out var itemsProperty) != true)
Comment on lines +298 to +299
Copy link
Preview

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code attempts to access Properties on Reference which is incorrect. The Reference property is a string reference to a schema definition, not the actual schema object. This should be accessing the resolved schema object instead of the reference.

Suggested change
var listSchema = response?.Schema?.Reference;
if (listSchema?.Properties?.TryGetValue("items", out var itemsProperty) != true)
// Resolve the schema reference to the actual schema object
var referencedSchema = response?.Schema?.ActualSchema;
if (referencedSchema?.Properties?.TryGetValue("items", out var itemsProperty) != true)

Copilot uses AI. Check for mistakes.

{
return null;
}
Comment on lines +298 to +302
Copy link
Preview

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method attempts to access Properties on a JsonReference object, but JsonReference doesn't have a Properties property. This will always return null. You should resolve the reference first to get the actual schema.

Suggested change
var listSchema = response?.Schema?.Reference;
if (listSchema?.Properties?.TryGetValue("items", out var itemsProperty) != true)
{
return null;
}
// Resolve the reference to the actual schema before accessing Properties
var referencedSchema = response?.Schema?.Reference as JsonSchema;
if (referencedSchema == null)
{
return null;
}
if (!referencedSchema.Properties.TryGetValue("items", out var itemsProperty))
{
return null;
}

Copilot uses AI. Check for mistakes.


if (itemsProperty.Reference != null)
{
return classNameHelper.GetClassNameForSchemaDefinition(itemsProperty.Reference);
}

Check warning on line 309 in src/LibKubernetesGenerator/TypeHelper.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

Check warning on line 309 in src/LibKubernetesGenerator/TypeHelper.cs

View workflow job for this annotation

GitHub Actions / Dotnet build (macOS-latest)

if (itemsProperty.Item?.Reference != null)
{
return classNameHelper.GetClassNameForSchemaDefinition(itemsProperty.Item.Reference);
}

return null;
}
}
}
Loading