Skip to content

Conversation

Duranna66
Copy link

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Duranna66
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

linux-foundation-easycla bot commented Jul 8, 2024

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2024
@brendandburns
Copy link
Contributor

@Duranna66 which of these two PRs should I review?

@Duranna66
Copy link
Author

@brendandburns last pr, where 3 days ago

@brendandburns
Copy link
Contributor

/lgtm

This looks good to me, but we need you to sign the CLA.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2024
@Duranna66
Copy link
Author

Hope I will do that on this weekends

@Duranna66
Copy link
Author

/easycla

1 similar comment
@Duranna66
Copy link
Author

/easycla

@callingmahendra
Copy link
Contributor

If CLA is an issue, I can also raise PR with the same changes. Let me know.

@Duranna66
Copy link
Author

If CLA is an issue, I can also raise PR with the same changes. Let me know.

I will try one more time

@Duranna66
Copy link
Author

/easycla

1 similar comment
@Duranna66
Copy link
Author

/easycla

@Duranna66
Copy link
Author

If CLA is an issue, I can also raise PR with the same changes. Let me know.

okey, i don't have time for changing my email and reopen pr( You can raise PR with the same changes

callingmahendra added a commit to callingmahendra/java that referenced this pull request Jul 21, 2024
@dasarathirout
Copy link
Contributor

/lgtm

This looks good to me, but we need you to sign the CLA.

Thanks!

Made PR #3582 with the same changes ,its passed CLA check

@brendandburns
Copy link
Contributor

closing in favor of #3582

k8s-ci-robot added a commit that referenced this pull request Jul 22, 2024
fix: correct work of DaemonSetIgnore #3545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants