-
Notifications
You must be signed in to change notification settings - Fork 557
Add support for the v5 protocol #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -2,6 +2,7 @@ import { promisify } from 'util'; | |||||
import { expect } from 'chai'; | ||||||
import WebSocket = require('isomorphic-ws'); | ||||||
import { ReadableStreamBuffer, WritableStreamBuffer } from 'stream-buffers'; | ||||||
import stream = require('stream'); | ||||||
|
import stream = require('stream'); | |
import stream from 'node:stream'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason one of these uses readUint8()
and the other uses readUInt8()
(note difference in casing of the i
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converted all to readUint8 The Internet seems to be ambiguous on which is the right casing. Both appear to work...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are three
console.log()
s left over.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, so embarrassing to leave test printfs in the PR :)
fixed.