deps: replace tslint with typescript-eslint #2162
Conversation
tslint has been deprecated. This commit replaces it with typescript-eslint.
k8s-ci-robot
added
approved
| export function findSuffix(quantity: string): string { | ||
| let ix = quantity.length - 1; | ||
| while (ix >= 0 && !/[\.0-9]/.test(quantity.charAt(ix))) { | ||
| while (ix >= 0 && !/[.0-9]/.test(quantity.charAt(ix))) { |
There was a problem hiding this comment.
I think this is a breaking change we want the escaped \. to just match vs in regexp which matches all characters?
There was a problem hiding this comment.
That change was related to this error:
11:26 error Unnecessary escape character: . no-useless-escape
Here are the docs for no-useless-escape. I can put it back and disable the lint rule for that line if you'd prefer.
EDIT: I think the rule is correct /[.]/.test('a') returns false, while /[.]/.test('.') returns true.
There was a problem hiding this comment.
ok, thanks for checking.
|
Looks good. One comment on a regexp, but maybe I'm missing something? Thanks for doing this! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, cjihrig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
tslint has been deprecated. This commit replaces it with typescript-eslint.
This is a proposed fix for #2116