Skip to content

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 6, 2025

This commit updates the CodeQL scanning job's permissions as recommended in several places.

Refs: https://github.com/octokit/types.ts/blob/bb399b2f7126e587f2d6ff590bf3cffb9560c542/.github/workflows/codeql.yml#L11-L14
Refs: github/codeql#8843
Fixes: #2193

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2025
@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, cjihrig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,cjihrig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c92fd7a into kubernetes-client:main Feb 6, 2025
8 checks passed
@cjihrig cjihrig deleted the codeql branch February 6, 2025 21:12
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 6, 2025

Looks like the problem on main is fixed: https://github.com/kubernetes-client/javascript/actions/runs/13187974785 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is the CodeQL integration used?

3 participants