Skip to content

Add a devcontainer, since the default for codespaces is node 16 :0 #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2025
Merged

Add a devcontainer, since the default for codespaces is node 16 :0 #2230

merged 1 commit into from
Feb 23, 2025

Conversation

brendandburns
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2025
cjihrig
cjihrig reviewed Feb 14, 2025
View reviewed changes
.github/dependabot.yml Outdated
- package-ecosystem: 'npm'
directory: '/'
target-branch: 'master'
target-branch: 'main'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this stop updating the v0.x branch? If it does intentionally, maybe we should just end-of-life the v0.x branch officially? I think it also means we would have two checks for the main branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with keeping this as long as it was on purpose. I wasn't sure if this was intentional or a left-over.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK it's necessary for having dependabot continue updating the master branch, but if anyone knows better, I'm happy to be wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on what I can see from the dependabot PRs is that it is bumping on master rather than release-1.x.
Should that be changed to release-1.x or do I miss something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be updating master for v0.x and main for v1.x, right? main is now the old release-1.x branch.

Here are examples of both branches being updated: #2268 and #2266.

@brendandburns
Copy link
Contributor Author

switched main back to master

cjihrig
cjihrig approved these changes Feb 23, 2025
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, cjihrig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,cjihrig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9f5e470 into kubernetes-client:main Feb 23, 2025
7 of 8 checks passed
@cjihrig cjihrig mentioned this pull request Feb 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@davidgamero davidgamero Awaiting requested review from davidgamero

@mstruebing mstruebing Awaiting requested review from mstruebing

Assignees

@cjihrig cjihrig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brendandburns @k8s-ci-robot @cjihrig @mstruebing