improve coverage for top.ts by covering topNodes. #2274
Conversation
k8s-ci-robot
added
approved
| 'error', | ||
| { | ||
| args: 'none', | ||
| destructuredArrayIgnorePattern: '^_', |
There was a problem hiding this comment.
I wish JavaScript had this built in. Is the intent to ignore anything that starts with _, or strictly _? If it is the latter, we might need a $ on the end.
There was a problem hiding this comment.
What do you think? I'm ok with both _ and _ignore etc, but if you feel strongly I'm happy to adapt.
There was a problem hiding this comment.
I'm also OK with both, I just wanted to verify.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, cjihrig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Another day, another Github Copilot authored improvement to test coverage.
I'll give Copilot 50% credit here, it copied the topPods test a little too closely and failed to figure out that there were some extra calls that needed to be mocked.
Still, faster than me doing it all myself by at least 50%.
Also added eslint rule to ignore
_in array destructuring, I think that is a good style change, but open to other opinions.