Skip to content

regenerate client #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

regenerate client #2599

wants to merge 3 commits into from

Conversation

mstruebing
Copy link
Member

@mstruebing mstruebing commented Aug 13, 2025

This updates the openapi generator regarding: #2189

as mentioned here: #2189 (comment)

There is an issue with the AbortSignal, I know it's not needed anymore in newer node versions but that means we need to adjust the generator first if we would want to remove it (or, but that would be a bad solution, patch the output of the generator in the kubernetes-client/javascript repository).

Maybe someone else knows how to fix it?
If not, I will go ahead and adjust the generator soonish.

AbortSignal was added in NodeJS 15.0.0 so it should be fine to use

EDIT: Just got reminded by a notification that this is in flight: #2583

@mstruebing mstruebing self-assigned this Aug 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 13, 2025
@0x5457
Copy link
Contributor

0x5457 commented Aug 13, 2025

Without modifying the openapi-generator, I tested two approaches to resolve the AbortSignal type import in the generated code:

  1. add a paths mapping in tsconfig.json.
{
  "compilerOptions": {
    "paths": {
      "node-fetch/externals": ["./node_modules/@types/node-fetch/externals.d.ts"]
    }
  }
}
  1. change moduleResolution back to "node"(same as openapi-generator (tsconfig.json)). This also seems to fix the resolution, although I’m not entirely sure about possible side effects—especially around the differences between ESM and CommonJS exports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants