regenerate client #2599
Merged
regenerate client #2599
+5,337
−48,820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
approved
|
Without modifying the openapi-generator, I tested two approaches to resolve the AbortSignal type import in the generated code:
{
"compilerOptions": {
"paths": {
"node-fetch/externals": ["./node_modules/@types/node-fetch/externals.d.ts"]
}
}
}
|
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjihrig, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the openapi generator regarding: #2189
as mentioned here: #2189 (comment)There is an issue with the AbortSignal, I know it's not needed anymore in newer node versions but that means we need to adjust the generator first if we would want to remove it (or, but that would be a bad solution, patch the output of the generator in the kubernetes-client/javascript repository).Maybe someone else knows how to fix it?If not, I will go ahead and adjust the generator soonish.
AbortSignalwas added in NodeJS 15.0.0 so it should be fine to useEDIT: Just got reminded by a notification that this is in flight: #2583