Fix syntax for environment variable exports #2636
Conversation
k8s-ci-robot
added
approved
| run: | | ||
| echo "export KUBERNETES_BRANCH=${{ github.event.inputs.kubernetesBranch }} >> ./settings" | ||
| echo "export GEN_COMMIT="${{ github.event.inputs.genCommit }}" >> ./settings" | ||
| echo "export KUBERNETES_BRANCH="${{ github.event.inputs.kubernetesBranch }}"" >> ./settings |
There was a problem hiding this comment.
Is it possible to mix single and double quotes on these lines? Or, maybe some of the quotes could be escaped? Right now, it's kind of confusing. I think you're intending to add quotes around the value of KUBERNETES_BRANCH, but it seems like the first added quote would match the quote before export and the second set of quotes would be an empty string. Maybe I'm misunderstanding the intention though?
There was a problem hiding this comment.
Single quotes for the branch name would be better as this wouldn't result in shell expanding when we would have some fancy branch names.
I'm not 100% sure if GitHub-actions would replace that value in single quotes, but I guess so:
| echo "export KUBERNETES_BRANCH="${{ github.event.inputs.kubernetesBranch }}"" >> ./settings | |
| echo "export KUBERNETES_BRANCH='${{ github.event.inputs.kubernetesBranch }}'" >> ./settings |
There was a problem hiding this comment.
Actually the real thing I'm trying to do is get rid of the end quote at settings" which was actually what was causing the issue. I think I could eliminate the interior quotes all together unless version is going to have spaces in it, which seems unlikely.
There was a problem hiding this comment.
Go ahead, sounds fine to me as well.
|
Addressed comment, please take another look. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, cjihrig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.