Skip to content

feat: populate cluster config from client.authentication.k8s.io/exec … #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
+37 −0
Merged

feat: populate cluster config from client.authentication.k8s.io/exec … #2399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee35f6b
feat: populate cluster config from client.authentication.k8s.io/exec …
ma-ts May 27, 2025
ec65195
fix: only do this when extensions is defined
ma-ts Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions kubernetes/base/config/exec_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ def run(self, previous_response=None):
kubernetes_exec_info['spec']['response'] = previous_response
if self.cluster:
kubernetes_exec_info['spec']['cluster'] = self.cluster.value
if self.cluster.value.get("extensions"):
for extension in self.cluster.value["extensions"]:
if extension["name"] == "client.authentication.k8s.io/exec":
kubernetes_exec_info["spec"]["cluster"]["config"] = extension["extension"]
break

self.env['KUBERNETES_EXEC_INFO'] = json.dumps(kubernetes_exec_info)
process = subprocess.Popen(
Expand Down
32 changes: 32 additions & 0 deletions kubernetes/base/config/exec_provider_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,38 @@ def test_with_cluster_info(self, mock):
obj = json.loads(mock.call_args.kwargs['env']['KUBERNETES_EXEC_INFO'])
self.assertEqual(obj['spec']['cluster']['server'], 'name.company.com')

@mock.patch("subprocess.Popen")
def test_with_cluster_info_from_exec_extension(self, mock):
instance = mock.return_value
instance.wait.return_value = 0
instance.communicate.return_value = (self.output_ok, "")
ep = ExecProvider(
self.input_with_cluster,
None,
ConfigNode(
"cluster",
{
"server": "name.company.com",
"extensions": [
{
"name": "client.authentication.k8s.io/exec",
"extension": {
"namespace": "myproject",
"name": "mycluster",
},
},
],
},
),
)
result = ep.run()
self.assertTrue(isinstance(result, dict))
self.assertTrue("token" in result)

obj = json.loads(mock.call_args.kwargs["env"]["KUBERNETES_EXEC_INFO"])
self.assertEqual(obj["spec"]["cluster"]["server"], "name.company.com")
self.assertEqual(obj["spec"]["cluster"]["config"]["namespace"], "myproject")
self.assertEqual(obj["spec"]["cluster"]["config"]["name"], "mycluster")

if __name__ == '__main__':
unittest.main()
Loading