Fix no_proxy reset in configuration.py #2459
Open
+0
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently,
self.no_proxy
is explicitly reset toNone
after being populated from environment variables (NO_PROXY
orno_proxy
). This effectively discards the loaded values and preventsno_proxy
from being respected when configuring the client.This commit removes the redundant assignment to
None
, ensuring that theno_proxy
environment variable is preserved and proxy bypass settings are applied as expected.Which issue(s) this PR fixes:
No issue has been opened yet. Let me know if needed.
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: