Skip to content

feat: add controller.enableSnapshotter chart config #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2024
Merged

feat: add controller.enableSnapshotter chart config #820

merged 1 commit into from
Dec 15, 2024

Conversation

@andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: add controller.enableSnapshotter chart config

Which issue(s) this PR fixes:

Fixes #722

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat: add controller.enableSnapshotter chart config

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 15, 2024
@coveralls
Copy link

coveralls commented Dec 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12338767964

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.566%
Totals Coverage Status
Change from base Build 12335982106: 0.0%
Covered Lines: 953
Relevant Lines: 1213
💛 - Coveralls

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit d21d7bb into kubernetes-csi:master Dec 15, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@gnufied gnufied Awaiting requested review from gnufied

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

csi-snapshotter complains about missing CRD's quite noisily in the logs when externalSnapshotter Helm value is set to disabled

3 participants

@andyzhangx @k8s-ci-robot @coveralls