-
Notifications
You must be signed in to change notification settings - Fork 286
Add support for multiple storage classes in Helm chart #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @Copilot. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: andyzhangx <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: andyzhangx <[email protected]>
Co-authored-by: andyzhangx <[email protected]>
Co-authored-by: andyzhangx <[email protected]>
Pull Request Test Coverage Report for Build 18305664509Details
💛 - Coveralls |
Overview
This PR adds support for creating multiple storage classes with different configurations in a single Helm chart installation, addressing the feature request to support scenarios like having separate storage classes for Delete and Retain reclaim policies.
Changes
New Feature:
storageClassesArrayAdded a new
storageClassesarray parameter invalues.yamlthat allows users to define multiple storage classes with different configurations:Backward Compatibility
The existing single
storageClassconfiguration continues to work exactly as before:Both configurations can even coexist if needed.
Smart Defaults
The implementation provides sensible defaults for optional fields:
reclaimPolicy:DeletevolumeBindingMode:ImmediateallowVolumeExpansion:trueTechnical Improvements
allowVolumeExpansionto correctly process explicitfalsevalues usinghasKeycheckrangefunction$) for accessing global values within the loopFiles Modified
charts/latest/csi-driver-nfs/templates/storageclass.yamlcharts/latest/csi-driver-nfs/values.yamlcharts/v4.11.0/csi-driver-nfs/templates/storageclass.yamlcharts/v4.11.0/csi-driver-nfs/values.yamlcharts/v4.10.0/csi-driver-nfs/templates/storageclass.yamlcharts/v4.10.0/csi-driver-nfs/values.yamlcharts/README.mdTesting
All changes have been thoroughly tested:
helm lintpasses for all chart versionsstorageClassconfigurationDocumentation
Updated
charts/README.mdwith:storageClassesparameter documentationFixes #[issue_number]
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.