Skip to content

feat: enable host process deployment for windows daemonset by default #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyzhangx merged 1 commit into from
Jan 12, 2025
Merged

feat: enable host process deployment for windows daemonset by default #904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ The following table lists the configurable parameters of the latest SMB CSI Driv
| `linux.resources.smb.limits.memory` | smb-csi-driver memory limits | `200Mi` |
| `linux.resources.smb.requests.cpu` | smb-csi-driver cpu requests limits | `10m` |
| `linux.resources.smb.requests.memory` | smb-csi-driver memory requests limits | `20Mi` |
| `windows.enabled` | whether enable windows feature | `false` |
| `windows.enabled` | whether enable windows feature | `true` |
| `windows.useHostProcessContainers` | whether deploy driver daemonset with HostProcess containers on windows | `true` |
| `windows.dsName` | name of driver daemonset on windows | `csi-smb-node-win` |
| `windows.removeSMBMappingDuringUnmount` | remove SMBMapping during unmount on Windows node windows | `true` |
Expand Down
Binary file modified charts/latest/csi-driver-smb-v0.0.0.tgz
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions charts/latest/csi-driver-smb/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ linux:
memory: 20Mi

windows:
enabled: false # Unless you already had csi proxy installed, windows.csiproxy.enabled=true is required
useHostProcessContainers: false
enabled: true
useHostProcessContainers: true
dsName: csi-smb-node-win # daemonset name
kubelet: 'C:\var\lib\kubelet'
removeSMBMappingDuringUnmount: true
Expand Down
Loading