Skip to content

feat: support base64password field in secret #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andyzhangx merged 1 commit into from
Jan 22, 2025
Merged

feat: support base64password field in secret #906

andyzhangx merged 1 commit into from
Jan 22, 2025

Conversation

@andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jan 18, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support base64password field in secret

Which issue(s) this PR fixes:

Fixes #573

Requirements:

Special notes for your reviewer:

Release note:

feat: support base64password field in secret

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 18, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2025
@coveralls
Copy link

coveralls commented Jan 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12878904348

Details

  • 2 of 18 (11.11%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 77.591%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/nodeserver.go 2 10 20.0%
pkg/smb/smb.go 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/smb/smb.go 1 76.7%
Totals Coverage Status
Change from base Build 12832245825: -0.9%
Covered Lines: 1108
Relevant Lines: 1428
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2025
@andyzhangx
Copy link
Member Author

andyzhangx commented Jan 18, 2025

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

andyzhangx commented Jan 18, 2025

/retest

@andyzhangx
Copy link
Member Author

andyzhangx commented Jan 19, 2025

/retest

@andyzhangx
Copy link
Member Author

andyzhangx commented Jan 19, 2025

/test pull-csi-driver-smb-e2e-windows-2019-hostprocess

@andyzhangx
Copy link
Member Author

andyzhangx commented Jan 20, 2025

/retest

@andyzhangx
Copy link
Member Author

andyzhangx commented Jan 21, 2025

/retest

@andyzhangx andyzhangx merged commit 7f78b7a into kubernetes-csi:master Jan 22, 2025
21 of 22 checks passed
@johanot johanot mentioned this pull request Jan 22, 2025
Closed
@andyzhangx andyzhangx mentioned this pull request Jan 22, 2025
Merged
@rhrmo rhrmo mentioned this pull request Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Seems certain characters in smb credentials break authentication.

3 participants

@andyzhangx @k8s-ci-robot @coveralls