fix: enable to use secrets with special characters

[mpatlasov]

If the password to SMB-server contained special characters (e.g. "foo,bar"), the mount failed. Now, when the password is passed to mount via "credentials=filename" option, then mount succeeds.

/kind bug

Fixes #507, #358, #573

Release note:

none

[k8s-ci-robot]

Hi @mpatlasov. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[andyzhangx]

/ok-to-test

[andyzhangx]

btw, sanity tests all failed with this PR: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-csi_csi-driver-smb/961/pull-csi-driver-smb-sanity/1938798037342097408

[coveralls]

Pull Request Test Coverage Report for Build 16896083151

Details

• 21 of 25 (84.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.05%) to 78.507%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/smb/smb_common_linux.go	13	17	76.47%

Totals
Change from base Build 16825067885:	0.05%
Covered Lines:	1125
Relevant Lines:	1433

---

💛 - Coveralls

[mpatlasov]

/test pull-csi-driver-smb-e2e-windows-2022

[mpatlasov]

@andyzhangx , I addressed your comments (and fixed test failures). Please take a look again.

[Copilot]

Pull Request Overview

This PR fixes a bug where SMB volume mounting fails when passwords contain special characters like commas, quotes, or backticks. The solution switches from passing credentials directly in the mount command line to writing them to a temporary credentials file when special characters are detected.

• Adds detection for special characters in passwords that could break mount command parsing
• Implements credentials file approach as fallback when special characters are present
• Modifies mount options format to support both direct and file-based credential passing

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
pkg/smb/smb_common_linux.go	Adds credential file creation logic and special character detection for mount options
pkg/smb/nodeserver.go	Adds special character detection function and modifies credential formatting based on character presence

[andyzhangx]

thanks, it lgtm in general now.

[mpatlasov]

Hey @andyzhangx , I made three changes in a new commit:

• Moved defer func to L44 (as you suggested here)
• Added new test-case to existing TestNodeStageVolume to dive into Mount() "if NeedsCredentialsOption() {..."
• Added new file smb_common_linux_test.go with tests for NeedsCredentialsOption()

[andyzhangx]

/retest

[andyzhangx]

/retest

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment