-
Notifications
You must be signed in to change notification settings - Fork 32
fix: Replace errors.Is
with errors.As
for error type checking
#66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pandaye The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @pandaye! |
…hecking `errors.Is` can't handle `*exec.ExitError` correctly. Use `errors.As` to ensure capturing and handling non - zero exit code errors.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What type of PR is this?
/kind bug
What this PR does / why we need it:
In
multipath.go
errors.Is
can't handle*exec.ExitError
correctly. Useerrors.As
to ensure capturing and handling non - zero exit code errors.Which issue(s) this PR fixes:
Requirements:
Special notes for your reviewer:
Release note: