- 
                Notifications
    You must be signed in to change notification settings 
- Fork 63
feat: Use WMI to implement Service related System APIs to reduce PowerShell overhead #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use WMI to implement Service related System APIs to reduce PowerShell overhead #389
Conversation
| Hi @laozc. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. | 
| /ok-to-test | 
| Do you have a point of contact inside Broadcom that can help review your work? | 
| /lgtm | 
| @randomvariable: changing LGTM is restricted to collaborators In response to this: 
 Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. | 
| 
 this is generally straightforward, we've used this method a lot internally. the docs are here https://learn.microsoft.com/en-us/windows/win32/cimwin32prov/win32-service | 
| @laozc mostly looks good. can we also write some tests for this change? | 
5cca786    to
    9ad5f3f      
    Compare
  
    | Added the interfaces for mock test class in the second PR with some basic unit test. | 
| @humblec Could you take a look again? Thanks. | 
d996e11    to
    38f40cc      
    Compare
  
    38f40cc    to
    897e125      
    Compare
  
    897e125    to
    8a7c3a0      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding unit tests to api_test.go! It seems that they're failing though.
| /approve | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, laozc, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
What type of PR is this?
/kind feature
What this PR does / why we need it:
Use WMI to implement Service related System APIs to reduce PowerShell overhead
Which issue(s) this PR fixes:
Partially for #193
Special notes for your reviewer:
Does this PR introduce a user-facing change?: