- 
                Notifications
    You must be signed in to change notification settings 
- Fork 63
feat: Migrate PathValid API to use Win32 API to reduce PowerShell overhead #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate PathValid API to use Win32 API to reduce PowerShell overhead #390
Conversation
| Hi @laozc. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. | 
| /ok-to-test | 
cb64885    to
    5c6afc6      
    Compare
  
    5c6afc6    to
    5be8f0b      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
5be8f0b    to
    453133a      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, please rebase/squash your changes onto a single commit https://kubernetes.io/docs/contribute/new-content/open-a-pr/#squashing-commits
453133a    to
    16813d9      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, laozc The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
What type of PR is this?
/kind feature
What this PR does / why we need it:
Migrate the PathValid API to use
GetFileAttributeto reduce PowerShell overhead.Which issue(s) this PR fixes:
Fixes #193
Special notes for your reviewer:
Does this PR introduce a user-facing change?: