- 
                Notifications
    You must be signed in to change notification settings 
- Fork 63
fix: Ensure COM threading apartment for API calls #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure COM threading apartment for API calls #392
Conversation
| Hi @laozc. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. | 
ff51537    to
    7ec3342      
    Compare
  
    3e2b425    to
    9a93b7b      
    Compare
  
    9a93b7b    to
    4b97534      
    Compare
  
    4b97534    to
    db83ecf      
    Compare
  
    | /ok-to-test | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, laozc The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
What type of PR is this?
/kind bug
What this PR does / why we need it:
COM objects needs to be called within System thread with COM library initialized with multi-threaded apartment when the COM objects are accessed in multi-threaded environment.
This PR warps all the COM related calls within
cim.WithCOMThreadto ensure the marshaller works.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: