Skip to content

use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages #278

wants to merge 1 commit into from
+1 −1

Conversation

liangyuanpeng
Copy link

@liangyuanpeng liangyuanpeng commented Jun 5, 2025 •
edited
Loading

releated:

fixes #277

It seems that this place was treated correctly before? But why did it recover? I haven't checked the history yet.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @liangyuanpeng!

It looks like this is your first PR to kubernetes-csi/csi-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-release-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2025
@ameukam
Copy link

ameukam commented Jun 6, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2025
@liangyuanpeng
Copy link
Author

@msau42 Could you help check whether this image meets the current csi usage requirements? You modified the namespace of the image in the following PR, but it seems that you only want to upgrade the image version?

/retest
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-csi_csi-release-tools/278/pull-kubernetes-csi-release-tools-external-provisioner/1930843731896832000

ok  	github.com/kubernetes-csi/external-provisioner/v5/pkg/capacity	26.314s
--- FAIL: TestNodeTopology (60.41s)
    --- FAIL: TestNodeTopology/change-labels (60.00s)
        nodes_test.go:551: unexpected error: get informers in sync: timed out waiting for the condition
FAIL
FAIL	github.com/kubernetes-csi/external-provisioner/v5/pkg/capacity/topology	60.860s

@xing-yang
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 30, 2025
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@xing-yang
Copy link
Contributor

The CVE is fixed. Please rebase.

@Rakshith-R Rakshith-R mentioned this pull request Jul 2, 2025
Open
@liangyuanpeng liangyuanpeng force-pushed the migrate_k8s_testimages branch from fe82c7d to 5ec1a52 Compare July 9, 2025 12:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@liangyuanpeng
Copy link
Author

liangyuanpeng commented Jul 9, 2025 •
edited
Loading

/retest

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-csi_csi-release-tools/278/pull-kubernetes-csi-release-tools-external-provisioner/1942922407836651520

  STEP: Destroying namespace "volume-expand-7977" for this suite. @ 07/09/25 13:00:22.832
  << Timeline
  [FAILED] While waiting for pvc to have fs resizing condition: error waiting for pvc "hostpath.csi.k8s.iojtcqb" to have filesystem resize status: error fetching pvc "hostpath.csi.k8s.iojtcqb" for checking for resize status : client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline
  In [It] at: k8s.io/kubernetes/test/e2e/storage/testsuites/volume_expand.go:238 @ 07/09/25 13:00:17.596

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-csi_csi-release-tools/278/pull-kubernetes-csi-release-tools-external-snapshotter/1942922407933120512

...
go: download go1.23.3: golang.org/[email protected]: read "https://proxy.golang.org/golang.org/toolchain/@v/v0.0.1-go1.23.3.linux-amd64.zip": write /home/prow/go/pkg/mod/cache/download/golang.org/toolchain/@v/v0.0.1-go1.23.3.linux-amd64.zip112168608.tmp: 
no space left on device
ERROR: Please install Go 1.21+
WARNING: E2E parallel features failed

@liangyuanpeng
Copy link
Author

liangyuanpeng commented Jul 10, 2025 •
edited
Loading

/retest

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-csi_csi-release-tools/278/pull-kubernetes-csi-release-tools-external-provisioner/1942962664179240960

WARNING: DATA RACE
Read at 0x00c0005cd380 by goroutine 233:

@liangyuanpeng
Copy link
Author

liangyuanpeng commented Jul 14, 2025 •
edited
Loading

csi-release-tools/pull-test.sh

Line 34 in 74e066a

git subtree pull --squash --prefix=release-tools "$CSI_RELEASE_TOOLS_DIR" master

Seems like it's using csi-release-tools master for jobs of pull-kubernetes-csi-release-tools-external-provisioner and pull-kubernetes-csi-release-tools-external-snapshotter , so it's not releated with this PR, right?

@gnufied I see that you have opened a PR: kubernetes/test-infra#35116 for this case, could you please confirm that? thanks.

@liangyuanpeng liangyuanpeng force-pushed the migrate_k8s_testimages branch from 087c1fd to 5ec1a52 Compare July 15, 2025 03:45
@liangyuanpeng liangyuanpeng mentioned this pull request Jul 15, 2025
Open
@gnufied
Copy link
Contributor

gnufied commented Jul 15, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

@liangyuanpeng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-release-tools-external-provisioner 5ec1a52 link false /test pull-kubernetes-csi-release-tools-external-provisioner
pull-kubernetes-csi-release-tools-external-snapshotter 5ec1a52 link false /test pull-kubernetes-csi-release-tools-external-snapshotter

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauriciopoppe mauriciopoppe Awaiting requested review from mauriciopoppe

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate away from gcr.io/k8s-testimages repo
5 participants
@liangyuanpeng @k8s-ci-robot @ameukam @xing-yang @gnufied