-
Notifications
You must be signed in to change notification settings - Fork 397
Introduce v1beta2 VolumeGroupSnapshot API #1312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leonardoce
wants to merge
12
commits into
kubernetes-csi:master
Choose a base branch
from
leonardoce:dev-v1beta2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43,942
−374
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2c24dc7
Introduce v1beta2 VolumeGroupSnapshot API
leonardoce 67d2939
Enable conversion webhook on CRDs
leonardoce faf832b
Use v1beta2 VolumeGroupSnapshot API instead of v1beta1
leonardoce c0e647a
Set new fields in VolumeGroupSnapshotContent objects
leonardoce c0c4750
Conversion webhook
leonardoce d1f9f39
Rename snapshot-webhook to snapshot-conversion-webhook
leonardoce 9ad300a
Conversion webhook review
leonardoce 6815d03
Remove stale validation webhook documentation, add paragraph about th…
leonardoce ba5e7fa
Drop support for v1beta1 ConversionReview requests
leonardoce 4870d73
Conversion webhook review
leonardoce 7cf9ba0
Update CEL tests
leonardoce 1c9ffa5
Remove reference to banzaicloud/admission-webhook-example
leonardoce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /* | ||
| Copyright 2025 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| // +k8s:deepcopy-gen=package | ||
| // +groupName=groupsnapshot.storage.k8s.io | ||
|
|
||
| package v1beta2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| Copyright 2025 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1beta2 | ||
|
|
||
| import ( | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| ) | ||
|
|
||
| // GroupName is the group name use in this package. | ||
| const GroupName = "groupsnapshot.storage.k8s.io" | ||
|
|
||
| var ( | ||
| // SchemeBuilder is the new scheme builder | ||
| SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes) | ||
| // AddToScheme adds to scheme | ||
| AddToScheme = SchemeBuilder.AddToScheme | ||
| // SchemeGroupVersion is the group version used to register these objects. | ||
| SchemeGroupVersion = schema.GroupVersion{Group: GroupName, Version: "v1beta2"} | ||
| ) | ||
|
|
||
| func Resource(resource string) schema.GroupResource { | ||
| return SchemeGroupVersion.WithResource(resource).GroupResource() | ||
| } | ||
|
|
||
| func init() { | ||
| // We only register manually written functions here. The registration of the | ||
| // generated functions takes place in the generated files. The separation | ||
| // makes the code compile even when the generated files are missing. | ||
| SchemeBuilder.Register(addKnownTypes) | ||
| } | ||
|
|
||
| // addKnownTypes adds the set of types defined in this package to the supplied scheme. | ||
| func addKnownTypes(scheme *runtime.Scheme) error { | ||
| scheme.AddKnownTypes(SchemeGroupVersion, | ||
| &VolumeGroupSnapshotClass{}, | ||
| &VolumeGroupSnapshotClassList{}, | ||
| &VolumeGroupSnapshot{}, | ||
| &VolumeGroupSnapshotList{}, | ||
| &VolumeGroupSnapshotContent{}, | ||
| &VolumeGroupSnapshotContentList{}, | ||
| ) | ||
| metav1.AddToGroupVersion(scheme, SchemeGroupVersion) | ||
| return nil | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be more like v1beta1 to v1beta2 upgrade. IMHO we need a new chapter. Or remove v1beta1 to v1 completely, it happened a long time ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can remove the v1beta1 to v1 section for VolumeSnapshot API now.
You can add a new section for VolumeGroupSnapshot.