Skip to content

Conversation

@skl
Copy link
Collaborator

@skl skl commented Jan 7, 2025

This PR has two sets of changes:

  • Adds the cluster label to any alert description where it was missing (currently inconsistent)
  • More robust de-dupe of pod count in KubeletTooManyPods alert

Fixes #997.

@skl skl added the enhancement New feature or request label Jan 7, 2025
@skl skl self-assigned this Jan 7, 2025
@skl skl requested a review from povilasv as a code owner January 7, 2025 14:06
Comment on lines +61 to +66
count by (%(clusterLabel)s, node) (
(kube_pod_status_phase{%(kubeStateMetricsSelector)s, phase="Running"} == 1)
* on (%(clusterLabel)s, namespace, pod) group_left (node)
group by (%(clusterLabel)s, namespace, pod, node) (
kube_pod_info{%(kubeStateMetricsSelector)s}
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the "More robust de-dupe of pod count in KubeletTooManyPods alert".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw this change is covered by an existing test:

kubernetes-mixin/tests.yaml

Lines 406 to 435 in 03c13f9

- interval: 1m
input_series:
- series: 'kube_node_status_capacity{resource="pods",instance="172.17.0.5:8443",cluster="kubernetes",node="minikube",job="kube-state-metrics",namespace="kube-system"}'
values: '3+0x15'
- series: 'kube_pod_info{endpoint="https-main",instance="172.17.0.5:8443",job="kube-state-metrics",cluster="kubernetes",namespace="kube-system",node="minikube",pod="pod-1",service="kube-state-metrics"}'
values: '1+0x15'
- series: 'kube_pod_status_phase{endpoint="https-main",instance="172.17.0.5:8443",job="kube-state-metrics",cluster="kubernetes",namespace="kube-system",phase="Running",pod="pod-1",service="kube-state-metrics"}'
values: '1+0x15'
- series: 'kube_pod_info{endpoint="https-main",instance="172.17.0.5:8443",job="kube-state-metrics",cluster="kubernetes",namespace="kube-system",node="minikube",pod="pod-2",service="kube-state-metrics"}'
values: '1+0x15'
- series: 'kube_pod_status_phase{endpoint="https-main",instance="172.17.0.5:8443",job="kube-state-metrics",cluster="kubernetes",namespace="kube-system",phase="Running",pod="pod-2",service="kube-state-metrics"}'
values: '1+0x15'
- series: 'kube_pod_info{endpoint="https-main",instance="172.17.0.5:8443",job="kube-state-metrics",cluster="kubernetes",namespace="kube-system",node="minikube",pod="pod-3",service="kube-state-metrics"}'
values: '1+0x15'
- series: 'kube_pod_status_phase{endpoint="https-main",instance="172.17.0.5:8443",job="kube-state-metrics",cluster="kubernetes",namespace="kube-system",phase="Running",pod="pod-3",service="kube-state-metrics"}'
values: '1+0x15'
alert_rule_test:
- eval_time: 10m
alertname: KubeletTooManyPods
- eval_time: 15m
alertname: KubeletTooManyPods
exp_alerts:
- exp_labels:
cluster: kubernetes
node: minikube
severity: info
exp_annotations:
summary: "Kubelet is running at capacity."
description: "Kubelet 'minikube' is running at 100% of its Pod capacity."
runbook_url: https://github.com/kubernetes-monitoring/kubernetes-mixin/tree/master/runbook.md#alert-name-kubelettoomanypods

@skl skl merged commit af5e898 into master Jan 13, 2025
18 checks passed
@skl skl deleted the skl/dedupe-KubeletTooManyPods branch January 13, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Prometheus rule KubeletTooManyPods incorrect statistics

2 participants