Skip to content

feat: filter NodeReadiness alerts on uncordoned status #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2025
Merged

feat: filter NodeReadiness alerts on uncordoned status #1012

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e88580b
feat: filter NodeReadiness alerts on uncordoned status
TheRealNoob Jan 17, 2025
30d35ea
add tests
TheRealNoob Jan 22, 2025
1688037
Update tests.yaml
skl Jan 23, 2025
d2f9d0a
Update tests.yaml
skl Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions alerts/kubelet.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ local utils = import '../lib/utils.libsonnet';
{
expr: |||
kube_node_status_condition{%(kubeStateMetricsSelector)s,condition="Ready",status="true"} == 0
and on (%(clusterLabel)s, node)
kube_node_spec_unschedulable{%(kubeStateMetricsSelector)s} == 0
||| % $._config,
labels: {
severity: 'warning',
Expand All @@ -30,7 +32,7 @@ local utils = import '../lib/utils.libsonnet';
description: '{{ $labels.node }} has been unready for more than 15 minutes%s.' % [
utils.ifShowMultiCluster($._config, ' on cluster {{ $labels.%(clusterLabel)s }}' % $._config),
],
summary: 'Node is not ready.',
summary: 'Schedulable Node is not ready.',
},
'for': '15m',
alert: 'KubeNodeNotReady',
Expand Down Expand Up @@ -85,6 +87,8 @@ local utils = import '../lib/utils.libsonnet';
alert: 'KubeNodeReadinessFlapping',
expr: |||
sum(changes(kube_node_status_condition{%(kubeStateMetricsSelector)s,status="true",condition="Ready"}[15m])) by (%(clusterLabel)s, node) > 2
and on (%(clusterLabel)s, node)
kube_node_spec_unschedulable{%(kubeStateMetricsSelector)s} == 0
||| % $._config,
'for': '15m',
labels: {
Expand All @@ -94,7 +98,7 @@ local utils = import '../lib/utils.libsonnet';
description: 'The readiness status of node {{ $labels.node }} has changed {{ $value }} times in the last 15 minutes%s.' % [
utils.ifShowMultiCluster($._config, ' on cluster {{ $labels.%(clusterLabel)s }}' % $._config),
],
summary: 'Node readiness status is flapping.',
summary: 'Schedulable Node readiness status is flapping.',
},
},
{
Expand Down
Loading