Use kube_statefulset_replicas for KubeStatefulSetReplicasMismatch
#1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [0] and [1] `kube_statefulset_status_replicas` returns "the number of Pods created by the StatefulSet controller". Therefore this alert only fires when the StatefulSet controller is able to create the pod, but it does not get ready. In cases where the controller is unable to create the pod (e.g. invalid pod spec) this alert does not fire. This is contrary to the expectation of firing when the statefulset does not match the configured amount of replicas. [0]: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.32/#statefulsetstatus-v1-apps [1]: https://github.com/kubernetes/kube-state-metrics/blob/2a95d4649b2fea55799032fb9c0b571c4ba7f776/internal/store/statefulset.go#L75
|
Thank you, @aeber. That was a very well-written description! Would you be interested in adding test cases for this alert I'm here to help if you have any questions. |
|
I gave it a try, not sure if this is the right way to do it though. I've added two test cases: one covering the old behavior and one demonstrating the issue that led to this PR. If there is anything i can improve, please let me know. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to 0 and 1
kube_statefulset_status_replicasreturns "the number of Pods created by the StatefulSet controller". Therefore this alert only fires when the StatefulSet controller is able to create the pod, but it does not get ready.In cases where the controller is unable to create the pod (e.g. invalid pod spec) this alert does not fire.
This is contrary to the expectation of firing when the statefulset does not match the configured amount of replicas.