fix: cluster variable in resources/cluster #1147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skl
reviewed
Nov 28, 2025
| local datasource = common.datasource(config); | ||
| local clusterVar = | ||
| common.cluster(config, datasource, 'up{%(kubeStateMetricsSelector)s}') | ||
| + var.query.generalOptions.showOnDashboard.withLabelAndValue(); |
Collaborator
There was a problem hiding this comment.
Can this go on the common variable definition instead? Otherwise this will have to be copy/pasted every time it's used.
Contributor
Author
There was a problem hiding this comment.
yes! I'll update that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous refactor broke cluster variable. The cluster dashboard never showed its cluster selector because that dashboard’s variable definition was different from every other dashboard. It was querying label values via cadvisor (
up{job="cadvisor"}) and hiding the control unlessshowMultiClusterwas enabled, so in most setups the query returned nothing and Grafana didn’t render the variable.This PR has it pointing at kube-state-metrics and forcing
showOnDashboard.withLabelAndValue()makes the variable populate and stay visible.