Skip to content

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Jul 10, 2023

When querying a child prometheus that uses federation to gather his metrics, an additional label is added to the metrics (eg: prometheus_replica). When a rollout is done on the parent prometheuses, there could be two metrics for the same time frame. This causes the scalar( function to return NaN as stated in the documentation, https://prometheus.io/docs/prometheus/latest/querying/functions/#scalar. Using scalar(max( instead of scalar( fixes the issue.

replaces #855

@aslafy-z aslafy-z marked this pull request as ready for review July 10, 2023 15:07
Copy link

github-actions bot commented Sep 8, 2024

This PR has been automatically marked as stale because it has not
had any activity in the past 30 days.

The next time this stale check runs, the stale label will be
removed if there is new activity. The issue will be closed in 7
days if there is no new activity.

Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 8, 2024
@aslafy-z aslafy-z requested a review from povilasv as a code owner September 9, 2024 13:26
@github-actions github-actions bot removed the stale label Sep 10, 2024
Copy link

This PR has been automatically marked as stale because it has not
had any activity in the past 30 days.

The next time this stale check runs, the stale label will be
removed if there is new activity. The issue will be closed in 7
days if there is no new activity.

Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 10, 2024
@aslafy-z
Copy link
Contributor Author

I will resolve conflicts asap

@aslafy-z
Copy link
Contributor Author

@povilasv Can you please give a look? Thank you

@github-actions github-actions bot removed the stale label Oct 11, 2024
@povilasv povilasv merged commit 6e24b64 into kubernetes-monitoring:master Oct 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants