File issues for totally broken suites

Author: lavalamp

mungegithub/mungers/e2e/e2e.go

@@ -144,6 +144,11 @@ func (e *RealE2ETester) getGCSResult(j cache.Job, n cache.Number) (*cache.Result
 	}
 	if len(thisFailures) == 0 {
 		r.Status = cache.ResultFailed
+		// We add a "flake" just to make sure this appears in the flake
+		// cache as something that needs to be synced.
+		r.Flakes = map[cache.Test]string{
+			cache.RunBrokenTestName: "Unable to get data-- please look at the logs",
+		}
 		return r, nil
 	}
 

mungegithub/mungers/flake-manager.go

@@ -124,18 +124,23 @@ func (p *FlakeManager) isIndividualFlake(f cache.Flake) bool {
 		return false
 	}
 
+	if len(f.Result.Flakes) > 0 {
+		// If this flake really represents an entire suite failure,
+		// this key will be present.
+		if _, ok := f.Result.Flakes[cache.RunBrokenTestName]; ok {
+			return false
+		}
+	}
+
 	return true
 }
 
 func (p *FlakeManager) listPreviousIssues(title string) []string {
-	if previousIssues := p.finder.AllIssuesForKey(title); len(previousIssues) > 0 {
-		s := []string{}
-		for _, i := range previousIssues {
-			s = append(s, fmt.Sprintf("#%v", i))
-		}
-		return s
+	s := []string{}
+	for _, i := range p.finder.AllIssuesForKey(title) {
+		s = append(s, fmt.Sprintf("#%v", i))
 	}
-	return nil
+	return s
 }
 
 // makeGubernatorLink returns a URL to view the build results in a GCS path.

mungegithub/mungers/flakesync/cache.go

@@ -44,6 +44,10 @@ const (
 	// ResultFailed means it failed without generating readable JUnit
 	// files, and introspection is not possible.
 	ResultFailed ResultStatus = "failed"
+
+	// RunBrokenTestName names a "flake" which really represents the fact
+	// that the entire run was broken.
+	RunBrokenTestName Test = "Suite so broken it failed to produce JUnit output"
 )
 
 // Result records a test job completion.