Create the necessary pieces in order to build a Kubernetes operator#363
Create the necessary pieces in order to build a Kubernetes operator#363esposem wants to merge 10 commits intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for agent-sandbox canceled.
|
|
Welcome @esposem! |
|
Hi @esposem. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: esposem The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Operator-sdk and kustomize uses them from config/ Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Copy everything except from the SA and ClusterRoleBinding, as they will go into rbac Also enable --extension in the controller, so we don't need two deployments. Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
@esposem: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an attempt to address #345 and create a Kubernetes operator to run agent-sandbox
Basically we fist need the right folder structure, with
config/andbundle/. This is usually generated by the operator-sdk but for some reason that was not the case here. So right now I tried to simply copy and refactor the necessary files into the right folders. I didn't modify the existing files.There are still a couple of open ended questions that would be nice to discuss:
--extensioncmdline is enabled in the controller. This was done to simplify the work and not have two deployments/controllers. Alternatively we can have a default configMap to load such options at runtime?k8s/. Should we move everything out ofk8s/? Or have symlinks into/config?Another option for the future is to keep the operator development in a separate branch until it successfully works.