Add unique label to pooled pods

[antonipp]

Description

This PR ensures that all Pods created by the WarmPool controller start with a unique label. This should be aligned well with the goals for all Sandboxes to have a unique and stable identity (https://github.com/kubernetes-sigs/agent-sandbox?tab=readme-ov-file#desired-sandbox-characteristics)

In our case, we need this for enforcing different Cilium Network Policies on each unique Sandbox once it's claimed from a Pool (CNPs rely on labels for selecting the Pods).

Note that it seems that someone else already had that idea:

agent-sandbox/extensions/controllers/sandboxwarmpool_controller.go

Line 252 in 1df7e4d

// pod.Labels[podNameLabel] = sandboxcontrollers.NameHash(pod.Name)

but the code which was commented out wouldn't work because the pod above uses GenerateName so pod.Name would be empty

Testing

Deployed to a cluster, created a WarmPool, verified that pods had the expected label:

$ kubectl get pods -l agents.x-k8s.io/pool=bb4771e4 -o jsonpath='{range .items[*]}{.metadata.name}{"\t"}{.metadata.labels.agents\.x-k8s\.io/pool-pod-id}{"\n"}{end}'
my-warmpool-g8s6d	500144bf-06d8-4db1-8a2c-d4ae4694735d
my-warmpool-t9bnj	d13cdb28-b358-449d-b3ec-562a6fbc4428

[netlify]

✅ Deploy Preview for agent-sandbox canceled.

Name	Link
🔨 Latest commit	fc2f0dd
🔍 Latest deploy log	https://app.netlify.com/projects/agent-sandbox/deploys/69bd06631e43c5000805a2d9

[k8s-ci-robot]

Hi @antonipp. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yongruilin]

@janetkuo do you think it is a valid proposal?

[natasha41575]

proposal seems sound to me

/lgtm

[natasha41575]

/assign @janetkuo
wdyt?

[k8s-ci-robot]

@antonipp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
presubmit-agent-sandbox-lint-api	6fdc461	link	true	/test presubmit-agent-sandbox-lint-api

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[yongruilin]

/retest

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: antonipp
Once this PR has been reviewed and has the lgtm label, please ask for approval from janetkuo. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• extensions/controllers/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment