[Part 1] Create a new Persistent Sandbox Handle#382
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom Mar 17, 2026
Merged
[Part 1] Create a new Persistent Sandbox Handle#382k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for agent-sandbox canceled.
|
k8s-ci-robot
added
size/XL
SHRUTI6991
changed the title
Contributor
Author
|
/assign @igooch |
tomergee
reviewed
Mar 11, 2026
clients/python/agentic-sandbox-client/k8s_agent_sandbox/core/command_execution.py
Outdated
Show resolved
Hide resolved
tomergee
reviewed
Mar 11, 2026
clients/python/agentic-sandbox-client/k8s_agent_sandbox/core/command_execution.py
Outdated
Show resolved
Hide resolved
SHRUTI6991
force-pushed
the
refactor_client_prs
branch
from
edd41c5 to
15cdd04
Compare
k8s-ci-robot
added
the
needs-rebase
Contributor
|
@SHRUTI6991: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
k8s-ci-robot
added
size/XXL
SHRUTI6991
force-pushed
the
refactor_client_prs
branch
from
15cdd04 to
3d8c33a
Compare
k8s-ci-robot
added
size/XL
igooch
reviewed
Mar 16, 2026
Contributor
igooch
left a comment
igooch
left a comment
There was a problem hiding this comment.
Overall looks good.
Adding a note that we may need to update the pyproject.toml to pick up the new subdirectories when publishing the SDK.
clients/python/agentic-sandbox-client/k8s_agent_sandbox/commands/command_execution.py
Outdated
Show resolved
Hide resolved
clients/python/agentic-sandbox-client/k8s_agent_sandbox/sandbox.py
Outdated
Show resolved
Hide resolved
clients/python/agentic-sandbox-client/k8s_agent_sandbox/connector.py
Outdated
Show resolved
Hide resolved
clients/python/agentic-sandbox-client/k8s_agent_sandbox/connector.py
Outdated
Show resolved
Hide resolved
clients/python/agentic-sandbox-client/k8s_agent_sandbox/trace_manager.py
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
size/XXL
SHRUTI6991
force-pushed
the
refactor_client_prs
branch
from
28984da to
8981b8c
Compare
k8s-ci-robot
added
size/XL
Contributor
Author
|
/assign @janetkuo |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: igooch, SHRUTI6991 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
Author
|
/unassign @janetkuo |
k8s-ci-robot
removed
the
lgtm
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
nadolskit
pushed a commit
to nadolskit/agent-sandbox
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on #359
Description
This PR introduces the Resource Handle abstraction for the Python SDK. This is the first step in a multi-part refactor aimed at moving away from the current context-manager-centric design. A lot of the code is porting existing code into new classes.
The goal of this PR is to define the core classes and logic for managing Sandboxes as independent "handles." This allows for resource management that can persist beyond a single code block and provides a cleaner interface for future client-side updates.
Note: This PR does not affect the client yet
Key changes
SandboxClass: Introduced a persistent handle for resource lifecycle management.SandboxConnector: Connects, closes and sends request to server based on the connection config defined by the userCommandExecutorandFileSystem: Explicit classes for execution based on the type.Future Work
Checklist
[x] I have performed a self-review of my own code.
[x] Logic is documented via docstrings for the new handle classes.
[x] Initial unit tests for Handle state transitions are included.
Full Demo
https://www.youtube.com/watch?v=khMLrf-vO9Y