Open
Conversation
✅ Deploy Preview for agent-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
size/L
Contributor
Author
|
/assign @janetkuo |
janetkuo
reviewed
Mar 19, 2026
janetkuo
reviewed
Mar 19, 2026
janetkuo
reviewed
Mar 19, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SHRUTI6991 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to expose
statusmethod for Sandboxes in the Python SDK: #280. The current outstanding implementation checks thePodstatus instead ofSandboxand transforms the Pod status into the Sandbox status on the client side. This is not an ideal implementation. We should exposestatusof the Sandbox on the controller side as a first class field.To align with Kubernetes API standards and address the previous limitations of using
phasefor Sandbox as discussed in #121, this proposal replaces the deprecatedstatus.phasefield withstatus.conditionsmodel. This model establishes three conditions:Initialised,ReadyandSuspended.