feat: add KEP-0174 for label and annotation propagation to sandbox pods#439
feat: add KEP-0174 for label and annotation propagation to sandbox pods#439chw120 wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for agent-sandbox canceled.
|
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @chw120. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/L
| // ... | ||
| AdditionalSandboxMetadata AdditionalSandboxMetadata `json:"additionalSandboxMetadata,omitempty"` | ||
| // Another option is to create AdditionalPodMetadata instead of depending on sandboxv1alpha1. | ||
| AdditionalPodMetadata sandboxv1alpha1.PodMetadata `json:"additionalPodMetadata,omitempty"` |
There was a problem hiding this comment.
why do you need additional metadata for both sandbox and pod ?
because sandbox additional metadata will propagate to the pod.
There was a problem hiding this comment.
I think I got this wrong. You're keeping labels/annotations at the sandbox separate from that of the pod. ok.
There was a problem hiding this comment.
Yeah it will give the users options to add the custom metadata to sandbox level, pod level, or both levels.
| #### Implementation Guidance | ||
|
|
||
| 1. The SandboxClaim controller propagates additional metadata to the assigned Sandbox resource. | ||
| 2. The Sandbox controller merges these values with the base template and injects them into the final Pod. |
There was a problem hiding this comment.
how are conflicts handled ?
There was a problem hiding this comment.
Yeah it's in "Safety Principle: No Overrides" section, that if a key exists with different values, the request will be rejected with an error.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aditya-shantanu, chw120 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 participants
This PR introduces KEP-174, which proposes a standardized mechanism to propagate labels and annotations from top-level user requests (SandboxClaim) down to the final compute resources (Pod).
Working on #174