Skip to content

upgrade base image to debian 13 #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgrade base image to debian 13 #1557

wants to merge 1 commit into from
+57 −58

Conversation

@huww98
Copy link
Contributor

@huww98 huww98 commented Nov 12, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Now all binaries are under /usr, we can remove the logic to search both.

Does this PR introduce a user-facing change?

Upgrade base image to debian 13

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/hold
For upstream distroless image is still preview.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 12, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huww98
Once this PR has been reviewed and has the lgtm label, please assign mowangdk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2025
@huww98 huww98 force-pushed the debian-13 branch 2 times, most recently from 14e9959 to c44dea3 Compare November 13, 2025 07:18
@huww98
Copy link
Contributor Author

huww98 commented Nov 14, 2025 •
edited
Loading

XFS (nvme5n1): Superblock has unknown incompatible features (0x20) enabled.

Looks like mkfs.xfs is too new and enabled some features that is not supported by alinux3 kernel.

#define XFS_SB_FEAT_INCOMPAT_NREXT64	(1 << 5)  /* large extent counters */

Available at Linux v5.19 torvalds/linux@919819f

@huww98
upgrade base image to debian 13
9ec3fc3 
Now all binaries are under /usr, we can remove the logic to search both.
huww98
huww98 commented Nov 14, 2025
View reviewed changes
pkg/utils/util.go
} else if fstype == "xfs" {
args = []string{
"-f",
"-i", "nrext64=0", // This requires kernel v5.19, so disable for now.
Copy link
Contributor Author

@huww98 huww98 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another reason to hold this. We will need to replace ASI dockerfile before merge. Old mkfs.xfs will not understand this flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iltyty iltyty Awaiting requested review from iltyty

@mowangdk mowangdk Awaiting requested review from mowangdk

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huww98 @k8s-ci-robot