make lease label and lease namespace configurable #670
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package util | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
| ) | ||
|
|
||
| // ParseLabels takes a comma-separated string of key-value pairs and returns a map of labels. | ||
| func ParseLabels(labelStr string) (map[string]string, error) { | ||
| labels := make(map[string]string) | ||
|
|
||
| if len(labelStr) == 0 { | ||
| return labels, fmt.Errorf("empty string provided") | ||
| } | ||
| pairs := strings.Split(labelStr, ",") | ||
|
|
||
| for _, pair := range pairs { | ||
| keyValue := strings.Split(pair, "=") | ||
| if len(keyValue) != 2 { | ||
ipochi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return nil, fmt.Errorf("invalid label format: %s", pair) | ||
| } | ||
| key := strings.TrimSpace(keyValue[0]) | ||
| value := strings.TrimSpace(keyValue[1]) | ||
| labels[key] = value | ||
| } | ||
| return labels, nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| package util | ||
|
|
||
| import ( | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestParseLabels(t *testing.T) { | ||
| testCases := []struct { | ||
| input string | ||
| expectedOutput map[string]string | ||
| shouldError bool | ||
| }{ | ||
| { | ||
| input: "app=myapp,env=prod,version=1.0", | ||
| expectedOutput: map[string]string{ | ||
| "app": "myapp", | ||
| "env": "prod", | ||
| "version": "1.0", | ||
| }, | ||
| shouldError: false, | ||
| }, | ||
| { | ||
|
Contributor
There was a problem hiding this comment. Would be nice to have a test case like "foo=var=baz" |
||
| input: "app=myapp,env=prod,invalid", | ||
| expectedOutput: nil, | ||
| shouldError: true, | ||
| }, | ||
| { | ||
| input: "app=myapp", | ||
| expectedOutput: map[string]string{ | ||
| "app": "myapp", | ||
| }, | ||
| shouldError: false, | ||
| }, | ||
| { | ||
| input: "", | ||
| expectedOutput: map[string]string{}, | ||
| shouldError: true, | ||
| }, | ||
| { | ||
| input: " key = value , another = test ", | ||
| expectedOutput: map[string]string{ | ||
| "key": "value", | ||
| "another": "test", | ||
| }, | ||
| shouldError: false, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| output, err := ParseLabels(tc.input) | ||
|
|
||
| // Check for unexpected errors or missing errors | ||
| if tc.shouldError && err == nil { | ||
| t.Errorf("expected error for input %q but got none", tc.input) | ||
| continue | ||
| } | ||
| if !tc.shouldError && err != nil { | ||
| t.Errorf("did not expect error for input %q but got: %v", tc.input, err) | ||
| continue | ||
| } | ||
|
|
||
| // Compare maps if there was no error | ||
| if !tc.shouldError { | ||
| if len(output) != len(tc.expectedOutput) { | ||
| t.Errorf("for input %q, expected map length %d but got %d", tc.input, len(tc.expectedOutput), len(output)) | ||
| } | ||
| for key, expectedValue := range tc.expectedOutput { | ||
| if output[key] != expectedValue { | ||
| t.Errorf("for input %q, expected %q=%q but got %q=%q", tc.input, key, expectedValue, key, output[key]) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.