Skip to content

Bump golangci/golangci-lint-action from 6 to 8 #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Bump golangci/golangci-lint-action from 6 to 8 #738

merged 1 commit into from
May 16, 2025

Conversation

@cheftako
Copy link
Contributor

@cheftako cheftako commented May 14, 2025

All lint-actions after 6 require you to use lint version 2+.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ipochi May 14, 2025 18:24
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from tallclair May 14, 2025 18:24
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2025
@cheftako
Copy link
Contributor Author

cheftako commented May 14, 2025

/assign @ipochi

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2025
@cheftako cheftako force-pushed the lint branch 3 times, most recently from 6bba77d to 5b62f3b Compare May 14, 2025 20:08
@cheftako
Bump golangci/golangci-lint-action from 6 to 8
216c026 
All lint-actions after 6 require you to use lint version 2+.
Pulled the 2.1 version of golangci-lint
Ran 'golangci-lint migrate'
Fixed concerns raised by linter.
@ipochi
Copy link
Contributor

ipochi commented May 15, 2025

@cheftako last time I tried to run golangci-lint v2.x on release-0.31 branch (which uses go v1.22). It didn't work.
May its the golangci-lint config that didn't allow it to run or go 1.22 was unsupported.

@cheftako
Copy link
Contributor Author

cheftako commented May 16, 2025 •
edited
Loading

Walter Fender last time I tried to run golangci-lint v2.x on release-0.31 branch (which uses go v1.22). It didn't work. May its the golangci-lint config that didn't allow it to run or go 1.22 was unsupported.

Did you have the included .golangci.yaml changes? I think we should make these changes on main anyway. I'm happy to try debugging if the cherrypick doesn't work, but I would like to try this since we should do it anyway.

@ipochi
Copy link
Contributor

ipochi commented May 16, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit aad0f25 into kubernetes-sigs:master May 16, 2025
22 checks passed
ipochi
ipochi reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

@ipochi ipochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cheftako cheftako mentioned this pull request May 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ipochi ipochi ipochi left review comments

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@ipochi ipochi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cheftako @k8s-ci-robot @ipochi