fix: avoid stale server count update #775
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Imran Pochi <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Contributor
Author
Contributor
Author
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, ipochi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ipochi
pushed a commit
to kinvolk/apiserver-network-proxy
that referenced
this pull request
Sep 17, 2025
…ervercount-update fix: avoid stale server count update (cherry picked from commit 62bba95)
ipochi
pushed a commit
to kinvolk/apiserver-network-proxy
that referenced
this pull request
Sep 17, 2025
…ervercount-update fix: avoid stale server count update (cherry picked from commit 62bba95)
ipochi
pushed a commit
to kinvolk/apiserver-network-proxy
that referenced
this pull request
Sep 17, 2025
…ervercount-update fix: avoid stale server count update (cherry picked from commit 62bba95)
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 19, 2025
…-release-0.33 Backport merge commit of #775 to release-0.33
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 19, 2025
…-release-0.32 Backport merge commit of #775 to release-0.32
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 19, 2025
…-release-0.31 Backport merge commit of #775 to release-0.31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #739
we only accept the server count from a server that we have successfully added to our active client set, implicitly ignoring stale data from duplicate connection attempts.
This problem in seen in all previous verison as well so this will need to be backported from v0.31 branch onwards where the a new logic is introduced to enable lease-counting.
However, that means additional dependency on kube-apiserver/etcd for the basic functionality of apiserver-network-proxy. If lease-counting is not enabled, then the problem remains of stale metadata.