-
Notifications
You must be signed in to change notification settings - Fork 849
feat: Expand plugin interface GetSegments() #2843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
3f043e5 to
0959e9b
Compare
Code Coverage Diff
|
0959e9b to
e393546
Compare
e393546 to
1a3db16
Compare
|
/retest |
|
This PR has multiple commits, and the default merge method is: merge. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6765ac5 to
926b09a
Compare
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes, also make verify is failing and needs to be fixed before merge.
pkg/driver/controller_test.go
Outdated
| AccessibleTopology: []*csi.Topology{ | ||
| { | ||
| Segments: map[string]string{WellKnownZoneTopologyKey: expZone}, | ||
| Segments: lo.Assign(map[string]string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetNodeSegments() returns an empty map here since nothing calls SetNodeSegments with actual data, so this test passes whether or not the merge works. Can we add a test that sets some segments and checks they show up in the response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is expected. Once a consumer has loaded the test with a plugin the segments will be updated to the correct value. This is how the remaining of the tests have been configured for the plugin
|
/assign @ConnorJC3 |
926b09a to
e62b106
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
edca3bb to
2b957c9
Compare
2b957c9 to
48384f8
Compare
What type of PR is this?
/kind feature
This change extends the EBS CSI driver plugin interface to support custom node topology segments that can be propagated to Kubernetes resources.
What is this PR about? / Why do we need it?
Dependencies:
How was this change tested?
make testDoes this PR introduce a user-facing change?