Skip to content

Add flake retries for Windows volume expansion tests#2878

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
torredil:windows-84123123123
Feb 26, 2026
Merged

Add flake retries for Windows volume expansion tests#2878
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
torredil:windows-84123123123

Conversation

@torredil
Copy link
Member

What type of PR is this?

/kind cleanup

What is this PR about? / Why do we need it?

Windows volume expansion tests can fail intermittently due to defragsvc contention causing GetSupportedSize (StorageWMI error 4) failures.

This PR splits the Windows external test run into two passes:

  • All non volume-expand tests run without retries
  • Volume expansion tests run with --flake-attempts

closes #2877

How was this change tested?

  • CI
  • make verify && make test

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 26, 2026
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2026
@github-actions
Copy link

Code Coverage Diff

This PR does not change the code coverage

@torredil torredil force-pushed the windows-84123123123 branch 3 times, most recently from 4b5a4e5 to 5416e55 Compare February 26, 2026 17:26
Signed-off-by: Eddie Torres <torredil@amazon.com>
@torredil torredil force-pushed the windows-84123123123 branch from 5416e55 to 31cf98e Compare February 26, 2026 19:22
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2026
Copy link
Member

@ElijahQuinones ElijahQuinones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElijahQuinones

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2026
@k8s-ci-robot k8s-ci-robot merged commit 27c7393 into kubernetes-sigs:master Feb 26, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows Resize Failures Observed in CI

4 participants