Rescan disks before resize operations on Windows#2881
Open
torredil wants to merge 1 commit intokubernetes-sigs:masterfrom
Open
Rescan disks before resize operations on Windows#2881torredil wants to merge 1 commit intokubernetes-sigs:masterfrom
torredil wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
Signed-off-by: Eddie Torres <torredil@amazon.com>
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
Code Coverage DiffThis PR does not change the code coverage |
ElijahQuinones
approved these changes
Mar 2, 2026
k8s-ci-robot
added
the
lgtm
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What is this PR about? / Why do we need it?
Both CSI proxy mounters have had a
Rescan()method in the interface since they were written, but it was never actually called anywhere. This wires it up before Resize operations on Windows so the host storage cache is refreshed (see https://learn.microsoft.com/en-us/powershell/module/storage/update-hoststoragecache) before we query disk sizes or extend a filesystem. Today, resize works without rescanning but this adds a safety margin against any edge case where the cache might be stale and its also a cheap call to make, so I consider it a defensive best practice.Rescan errors are logged and not treated as fatal since the resize and size check operations that follow are what actually matter.
How was this change tested?
CI
Does this PR introduce a user-facing change?