feat: added support for externalId in cross-account EFS configuration

[andylim0221]

Is this a bug fix or adding new feature?
Adding new feature

What is this PR about? / Why do we need it?
added optional value externalId in cross-account assume role secret

What testing is done?

1. Deployed this helm chart with private image in an EKS cluster
2. Setup the permissions required between account A and B
3. Setup the StorageClass, Secret, PVC and Pod in the cross-account example doc
4. The secret contains the following information:
   • awsRoleArn: <REDACTED>
   • externalId: <REDACTED>
   • crossaccount: true
5. Able to assume role from the controller SA

Related issue: #1688

[linux-foundation-easycla]

• ✅login: andylim0221 / name: andylim0221 / (91270d4)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @andylim0221!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @andylim0221. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andylim0221
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andylim0221]

@dankova22 could you help to review this? Thank you so much for your time.

[andylim0221]

Hi @dankova22, let me know what's missing or blocker so that we can proceed this PR? Thank you in advance

[wolszakp]

Hi @dankova22 - any updates in this topic? It's blocking us to move forward.