Skip to content

feat: added support for externalId in cross-account EFS configuration #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: added support for externalId in cross-account EFS configuration #1690

wants to merge 1 commit into from
+35 −12

Conversation

andylim0221
Copy link

@andylim0221 andylim0221 commented Aug 26, 2025 •
edited
Loading

Is this a bug fix or adding new feature?
Adding new feature

What is this PR about? / Why do we need it?
added optional value externalId in cross-account assume role secret

What testing is done?

  1. Deployed this helm chart with private image in an EKS cluster
  2. Setup the permissions required between account A and B
  3. Setup the StorageClass, Secret, PVC and Pod in the cross-account example doc
  4. The secret contains the following information:
    • awsRoleArn: <REDACTED>
    • externalId: <REDACTED>
    • crossaccount: true
  5. Able to assume role from the controller SA

Related issue: #1688

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 26, 2025 •
edited
Loading

CLA Signed

  • ✅login: andylim0221 / name: andylim0221 / (91270d4)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 26, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @andylim0221!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @andylim0221. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andylim0221
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 26, 2025
@andylim0221
Copy link
Author

@dankova22 could you help to review this? Thank you so much for your time.

@andylim0221
Copy link
Author

Hi @dankova22, let me know what's missing or blocker so that we can proceed this PR? Thank you in advance

@wolszakp
Copy link

wolszakp commented Oct 3, 2025 •
edited
Loading

Hi @dankova22 - any updates in this topic? It's blocking us to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dankova22 dankova22 Awaiting requested review from dankova22

@justinsb justinsb Awaiting requested review from justinsb

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andylim0221 @k8s-ci-robot @wolszakp