Skip to content

Conversation

Trickybrain
Copy link
Contributor

@Trickybrain Trickybrain commented Aug 22, 2025

PodLabel

Is this a bug fix or adding new feature?
This PR is adding a new feature - enabling users to specify custom pod labels for the FSx CSI driver controller and node components.

What is this PR about? / Why do we need it?
This PR enhances the AWS FSx CSI driver Helm chart by parameterizing pod labels for both the controller deployment and node daemonset. This allows users to add custom labels to the pods, which can be useful for:

Better pod identification and filtering in large clusters
Integration with monitoring, security, or compliance tools that rely on pod labels
Enabling organization-specific labeling standards
The implementation adds new configuration options (controller.podLabels and node.podLabels) to the values.yaml file, which are then applied to the respective pod template specs.

What testing is done?
The changes have been tested by:

Verifying that the chart installs successfully with default values
Testing the chart with custom pod labels specified for both controller and node components

Timeout

Is this a bug fix or adding new feature?
This allows the configuration of a previously hard coded setting that controls the timeout of call to the csi driver.
#433

What is this PR about? / Why do we need it?
AWS had an issue taking the provisioning of file systems longer than the 5m default. Now this setting is configurable.

What testing is done?
Deployment with a timeout of 15m during the time that provisioning was taking longer than 5min.

Attribution

This PR builds upon the work of:

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Trickybrain. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2025
@Trickybrain Trickybrain changed the title Add podLabels parameter - Original work by @bueti in PR #416 Add podLabels parameter Original work by @bueti in PR #416 and Allow timeout to be set Original work by @coolstim in PR #435 Aug 22, 2025
Original work by bueti in PR 416
Original work by coolstim PR 435
@Trickybrain Trickybrain changed the title Add podLabels parameter Original work by @bueti in PR #416 and Allow timeout to be set Original work by @coolstim in PR #435 Add podLabels parameter Original work by bueti in PR 416 and Allow timeout to be set Original work by coolstim in PR 435 Aug 22, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 22, 2025
@k8s-ci-robot
Copy link
Contributor

@Trickybrain: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@khoang98
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2025
@khoang98
Copy link
Contributor

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2025
@khoang98 khoang98 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Trickybrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a5ba127 into kubernetes-sigs:master Aug 25, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants