-
Notifications
You must be signed in to change notification settings - Fork 91
Add podLabels parameter Original work by bueti in PR 416 and Allow timeout to be set Original work by coolstim in PR 435 #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @Trickybrain. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f3f063f
to
e803e60
Compare
Original work by bueti in PR 416
Original work by coolstim PR 435
e803e60
to
fd9e97c
Compare
@Trickybrain: Re-titling can only be requested by trusted users, like repository collaborators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Trickybrain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PodLabel
Is this a bug fix or adding new feature?
This PR is adding a new feature - enabling users to specify custom pod labels for the FSx CSI driver controller and node components.
What is this PR about? / Why do we need it?
This PR enhances the AWS FSx CSI driver Helm chart by parameterizing pod labels for both the controller deployment and node daemonset. This allows users to add custom labels to the pods, which can be useful for:
Better pod identification and filtering in large clusters
Integration with monitoring, security, or compliance tools that rely on pod labels
Enabling organization-specific labeling standards
The implementation adds new configuration options (controller.podLabels and node.podLabels) to the values.yaml file, which are then applied to the respective pod template specs.
What testing is done?
The changes have been tested by:
Verifying that the chart installs successfully with default values
Testing the chart with custom pod labels specified for both controller and node components
Timeout
Is this a bug fix or adding new feature?
This allows the configuration of a previously hard coded setting that controls the timeout of call to the csi driver.
#433
What is this PR about? / Why do we need it?
AWS had an issue taking the provisioning of file systems longer than the 5m default. Now this setting is configurable.
What testing is done?
Deployment with a timeout of 15m during the time that provisioning was taking longer than 5min.
Attribution
This PR builds upon the work of: