Skip to content

[WIP] feat: support SMB mount with managed identity #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jul 5, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support SMB mount with managed identity

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

# k exec -it -n kube-system csi-azurefile-node-ls278 -c azurefile -- sh
# azfilesrefresh
Traceback (most recent call last):
  File "/usr/bin/azfilesrefresh", line 3, in <module>
    from azfilesauth import azfiles_set_oauth, get_oauth_token
ModuleNotFoundError: No module named 'azfilesauth'
# azfilesauthmanager

Usage:
        azfilesauthmanager list
        azfilesauthmanager set <file_endpoint_uri> <oauth_token>
        azfilesauthmanager set <file_endpoint_uri> --imds-client-id <client_id>
        azfilesauthmanager clear <file_endpoint_uri>

# ls -lt /usr/bin/azfile*
-rwxr-xr-x 1 root root 6862 May  3 12:00 /usr/bin/azfilesauthmanager
-rwxr-xr-x 1 root root 4649 May  3 12:00 /usr/bin/azfilesrefresh

Release note:

feat: support SMB mount with managed identity

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from cvvz and ZeroMagic July 5, 2025 02:46
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2025
@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2025
@andyzhangx andyzhangx force-pushed the mi branch 2 times, most recently from 08d98cd to 5564b5c Compare July 21, 2025 14:03
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2025
chore: add kubelet mount path

chore: mkdir kubeberos dir

fix

fix

install sudo curl

revert

fix mountOptions

support clientID

support clientID in sc

fix sh script golint error

fix

fix config file creation on host

add SETUP_MI_AUTH env var

fix azfilesauth_1.0 package

add azfilesrefresh sidecar

feat: mount with managed identity auth

fix
fix chart config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants