Skip to content

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jul 6, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support nfs volume clone and snapshot restore

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

I0706 15:15:32.397069       1 utils.go:105] GRPC call: /csi.v1.Controller/CreateVolume
I0706 15:15:32.397092       1 utils.go:106] GRPC request: {"capacity_range":{"required_bytes":107374182400},"name":"pvc-0d58dc6a-84b9-4bcc-b4aa-4cc3ff2543bd","parameters":{"csi.storage.k8s.io/pv/name":"pvc-0d58dc6a-84b9-4bcc-b4aa-4cc3ff2543bd","csi.storage.k8s.io/pvc/name":"pvc-azurefile-snapshot-restored2","csi.storage.k8s.io/pvc/namespace":"default","protocol":"nfs","resourceGroup":"andy-dev","storageAccount":"andynfs"},"volume_capabilities":[{"AccessType":{"Mount":{"mount_flags":["nconnect=4","noresvport","actimeo=30"]}},"access_mode":{"mode":5}}],"volume_content_source":{"Type":{"Snapshot":{"snapshot_id":"MC_andy-aks133_andy-aks133_eastus2euap#fe96b913cf7ba475692f8b7#pvcn-c876738d-62ab-47b5-89c7-68f21cc6d181###default#2025-07-06T07:52:19.0000000Z"}}}}
I0706 15:15:32.397496       1 azure.go:224] updateSubnetServiceEndpoints on vnetName: aks-vnet-16027573, subnetName: , location: eastus2euap
I0706 15:15:32.397521       1 azure.go:236] subnet  under vnet aks-vnet-16027573 in rg MC_andy-aks133_andy-aks133_eastus2euap is already updated, vnetResourceIDs: [/subscriptions/b9d2281e-dcd5-4dfd-9a97-0d50377cdf76/resourceGroups/MC_andy-aks133_andy-aks133_eastus2euap/providers/Microsoft.Network/virtualNetworks/aks-vnet-16027573/subnets/aks-subnet]
I0706 15:15:32.397662       1 controllerserver.go:482] source volume account name: fe96b913cf7ba475692f8b7, sourceID: MC_andy-aks133_andy-aks133_eastus2euap#fe96b913cf7ba475692f8b7#pvcn-c876738d-62ab-47b5-89c7-68f21cc6d181###default#2025-07-06T07:52:19.0000000Z
I0706 15:15:32.669137       1 controllerserver.go:607] begin to create file share(pvcn-0d58dc6a-84b9-4bcc-b4aa-4cc3ff2543bd) on account(andynfs) type(Premium_LRS) subID() rg(andy-dev) location() size(100) protocol(NFS)
I0706 15:15:33.312934       1 azurefile_mgmt_client.go:87] created share pvcn-0d58dc6a-84b9-4bcc-b4aa-4cc3ff2543bd in account andynfs
I0706 15:15:33.312957       1 controllerserver.go:1447] use user assigned managed identity to authorize azcopy
I0706 15:15:33.326315       1 controllerserver.go:1170] azcopy job status: NotFound, copy percent: %, error: <nil>
I0706 15:15:33.326332       1 controllerserver.go:1188] copy fileshare fe96b913cf7ba475692f8b7:pvcn-c876738d-62ab-47b5-89c7-68f21cc6d181(snapshot: 2025-07-06T07:52:19.0000000Z) to andynfs:pvcn-0d58dc6a-84b9-4bcc-b4aa-4cc3ff2543bd
I0706 15:15:36.891766       1 controllerserver.go:1205] copied fileshare pvcn-c876738d-62ab-47b5-89c7-68f21cc6d181(snapshot: 2025-07-06T07:52:19.0000000Z) to pvcn-0d58dc6a-84b9-4bcc-b4aa-4cc3ff2543bd successfully

Release note:

feat: support nfs volume clone and snapshot restore

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cvvz and gnufied July 6, 2025 08:46
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2025
@andyzhangx andyzhangx changed the title [WIP] feat: support nfs volume clone and snapshot restore feat: support nfs volume clone and snapshot restore Aug 9, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2025
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 2036d65 into master Aug 9, 2025
27 of 28 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.33

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #2713

In response to this:

/cherrypick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants